Add core SSL trust store resolution and fallback logic (PR 2 of 3)#786
Merged
Conversation
madhav-db
changed the title
madhav-db
changed the title
madhav-db
force-pushed
the
ssl-truststore-handling-2
branch
from
3193e0d to
a792846
Compare
Collaborator
vikrantpuppala
left a comment
vikrantpuppala
left a comment
There was a problem hiding this comment.
Sorry but there are severe logic flaws in this code, can we please manually test all flows that we're making changes to? I am afraid I will miss out something in one of these reviews and we're going to push out regressions.
vikrantpuppala
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the baseline SSL trust-store resolution logic and associated tests, enabling basic support for loading custom trust stores and handling fallbacks.
Flow explanation: https://docs.google.com/document/d/1TSfUsci3n9dXzXcnaYCNG7i7bmQo-PkXBQY1QrHzkpg/edit?tab=t.0#heading=h.ofrwhzeixs4q
Changes
SocketFactoryUtilfor test and self-signed certsConfiguratorUtilslogic for:SSLTestfor direct/proxy connections with trust store supportConfiguratorUtilsTestfor baseline pathsTesting
Tested with the
SSLTestintegration suite and unit test coverage inConfiguratorUtilsTest.Additional Notes to the Reviewer
This is PR 2 of 3 for the SSL configuration enhancement work.
NO_CHANGELOG=true
Will add changelog in last PR.